[FIX+Spec] Fractional not being BigDecimal upon deserialization #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal can end up being set to a Float. We need to ensure it is BigDecimal before calling #round with two paramers. Float class only provides #round with 0 or 1 parameter. Spec included.
| @@ -146,6 +146,35 @@ def expectation.fractional | |||
| m.fractional.should be_a(Fixnum) | |||
| end | |||
| end | |||
|
|
|||
| it "when loading a serialized Money object from YAML fractional rounding always works on bigdecimal" do | |||
There was a problem hiding this comment.
context "loading a serialized Money via YAML" do
it "uses BigDecimal when rounding" do
|
Please figure out why this is failing with ruby-1.9.2-p320 and fix. Thanks for the patch! |
added 2 commits
December 2, 2012 09:59
…it comment to 80 col width.
…r ruby-1.9.2-p320
semmons99
added a commit
that referenced
this pull request
Dec 5, 2012
[FIX+Spec] Fractional not being BigDecimal upon deserialization
|
Thanks for the patch @klevo, sorry I didn't merge it sooner. You now have a commit bit on the repo. |
|
awesome, thanks! On Dec 5, 2012, at 5:21 AM, Shane Emmons notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a YAML serialized money object is a common use case when dealing with persisting the money object in a queue, for example delayed_job. We need to ensure
@fractionalis BigDecimal before calling #round with two parameters on it. Float class only provides #round with 0 or 1 parameter. Spec included.